Re: [PATCH] fs/super.c: use && instead of & for warn_on condition

From: Oleg Nesterov
Date: Mon Sep 21 2015 - 11:43:10 EST


On 09/21, Vincent Stehlé wrote:
>
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1199,7 +1199,7 @@ int __sb_start_write(struct super_block *sb, int level, bool wait)
> else
> ret = percpu_down_read_trylock(sb->s_writers.rw_sem + level-1);
>
> - WARN_ON(force_trylock & !ret);
> + WARN_ON(force_trylock && !ret);

OOPS! yes, this is a typo, thanks! Harmless in this particular case,
but still.

Acked-by: Oleg Nesterov <oleg@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/