Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap

[Andrew F. Davis]

On 09/19/2015 01:40 PM, Mark Brown wrote:
> On Tue, Sep 15, 2015 at 12:57:40PM -0500, Andrew F. Davis wrote:
> > The old driver does not support DT. Rewrite the driver adding DT support
> > and use modern kernel features such as regmap and related helpers.
> >
> > Signed-off-by: Andrew F. Davis <afd@xxxxxx>
> > ---
> >   drivers/gpio/gpio-tps65912.c           | 291 ++++++------
> >   drivers/mfd/Kconfig                    |  20 +-
> >   drivers/mfd/Makefile                   |   3 +-
> >   drivers/mfd/tps65912-core.c            | 288 +++++-------
> >   drivers/mfd/tps65912-i2c.c             | 233 ++++------
> >   drivers/mfd/tps65912-irq.c             | 217 ---------
> >   drivers/mfd/tps65912-spi.c             | 236 ++++------
> >   drivers/regulator/tps65912-regulator.c | 783 ++++++++++-----------------------
> >   include/linux/mfd/tps65912.h           | 256 +++++++----
> >   9 files changed, 854 insertions(+), 1473 deletions(-)
>
> It's not OK to have a single commit that rewrites multiple drivers over
> many subsystems, that's really not something that can be sensibly
> reviewed.  You should split this into a patch series which makes one
> specific change at a time as covered in SubmittingPatches.  That will
> allow the changes to be reviewed much more sensibly.

I know this is hard to review, and so I would like to apologize in advance, but
the regulator and GPIO changes depend on the new driver core, as do the i2c/spi
components. I really don't know how to split this up without leaving some part
in a non-working state in-between patches (which I've heard is also not OK).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/