Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap

[Andrew F. Davis]

On 09/21/2015 02:54 PM, Mark Brown wrote:
> On Mon, Sep 21, 2015 at 02:46:50PM -0500, Andrew F. Davis wrote:
> > On 09/21/2015 02:26 PM, Mark Brown wrote:
>
> > > So split that interface change between the MFD and the function drivers
> > > out into a separate change - you've got way more than just an interface
> > > change in here (and you've not enumerated the various things that are
> > > being changed in the changelog).
>
> > I'm not really "changing" anything, this is a ground-up re-write. This
> > fundamentally changes the way the MFD core and the function drivers interact,
> > I would consider this a whole new driver that just happens to replace an older
> > driver, not a bunch of incremental changes although I kept the same filenames.
>
> So split out the deletion then add the new driver like you'd add any
> other new driver.  If there were in tree users even that would be really
> problematic but it does seem like we don't have any so perhaps people
> will be OK with this.

OK, I'll split that in v2.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/