Re: [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this_cpu() for cpu hotplug

[Thomas Gleixner]

On Wed, 23 Sep 2015, Yang Yingliang wrote:
> On 2015/9/23 2:54, Thomas Gleixner wrote:
> > On Sat, 19 Sep 2015, Yang Yingliang wrote:
> > 
> > > Add irq_migrate_all_off_this_cpu() into kernel/irq/migration.c.
> > 
> > This doesn't make any sense at all.
> > 
> > You just reuse the existing file to stick your new code into it
> > without reusing a single bit in that file. Aside of that it's
> > unconditionally compiled, which means all existing users of
> > CONFIG_GENERIC_PENDING_IRQ are burdened with pointless code.
> > 
> > The right thing to do is:
> > 
> > Add that code to a new file: kernel/irq/cpuhotplug.c and make that
> > depend on CONFIG_GENERIC_IRQ_MIGRATION.
> 
> How about add #ifdef CONFIG_CPU_HOTPLUG around new code
> in kernel/irq/migration.c ?

What's the point? Just to have useless churn and ifdeffery in that
file for nothing?

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/