Re: [PATCH] arm64/pci: Add quirks for Cavium Thunder PCI bridges.

[David Daney]

On 09/23/2015 11:40 AM, Will Deacon wrote:
> On Wed, Sep 23, 2015 at 01:09:56AM +0100, David Daney wrote:
> > From: David Daney <david.daney@xxxxxxxxxx>
> >
> > The Cavium ThunderX SoC needs a PCI quirk for its on-chip bridges.
> > Since it is arm64, create a new quirks.c file there to contain arm64
> > related quirks.  Add the ThunderX bridge quirk, gated by a new config
> > variable, so that it can be disabled for kernels that aren't expected
> > to be used on ThunderX.
> >
> > Signed-off-by: David Daney <david.daney@xxxxxxxxxx>
> > ---
> >   arch/arm64/Kconfig         | 11 +++++++++++
> >   arch/arm64/kernel/Makefile |  2 +-
> >   arch/arm64/kernel/quirks.c | 36 ++++++++++++++++++++++++++++++++++++
> >   3 files changed, 48 insertions(+), 1 deletion(-)
> >   create mode 100644 arch/arm64/kernel/quirks.c
>
> Why does this have to live in the arch/arm64/ directory? The quirks have
> nothing to do with the architecture code.

It doesn't have to live there.  It is something that will never be used 
for any other architecture.  So I thought we could do like 
arch/x86/kernel/quirks.c

I could move it to drivers/pci/quirks.c if people think that is a much 
better place for it.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/