Re: [PATCH 3.10 02/20] iio: bmg160: IIO_BUFFER and IIO_TRIGGERED_BUFFER are required

[Markus Pargmann]

Hi,

On Tue, Sep 22, 2015 at 11:30:25PM +0100, Luis Henriques wrote:
> On Sat, Sep 19, 2015 at 10:27:17AM -0700, Greg Kroah-Hartman wrote:
> > 3.10-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Markus Pargmann <mpa@xxxxxxxxxxxxxx>
> > 
> > commit 06d2f6ca5a38abe92f1f3a132b331eee773868c3 upstream.
> > 
> > This patch adds selects for IIO_BUFFER and IIO_TRIGGERED_BUFFER. Without
> > IIO_BUFFER, the driver does not compile.
> > 
> > Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx>
> > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > 
> > ---
> >  drivers/iio/gyro/Kconfig |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > --- a/drivers/iio/gyro/Kconfig
> > +++ b/drivers/iio/gyro/Kconfig
> > @@ -73,7 +73,8 @@ config IIO_ST_GYRO_SPI_3AXIS
> >  config ITG3200
> 
> I know it's a bit too late as this kernel has been released already,
> but this patch doesn't look right to me.  The original patch is
> changing the BMG160 driver, not the ITG3200.
> 
> The same applies to the 3.14 kernel -- it's changing the wrong
> driver.

Thanks, this is right. I didn't notice this but the driver was
introduced in 3.18:
	22b46c45fb9b (iio:gyro:bmg160 Gyro Sensor driver)

Best Regards,

Markus

> 
> Cheers,
> --
> LuÃs
> 
> >  	tristate "InvenSense ITG3200 Digital 3-Axis Gyroscope I2C driver"
> >  	depends on I2C
> > -	select IIO_TRIGGERED_BUFFER if IIO_BUFFER
> > +	select IIO_BUFFER
> > +	select IIO_TRIGGERED_BUFFER
> >  	help
> >  	  Say yes here to add support for the InvenSense ITG3200 digital
> >  	  3-axis gyroscope sensor.
> > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe stable" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: Digital signature