Re: + kernelh-make-abs-work-with-64-bit-types.patch added to -mm tree

[Michal Nazarewicz]

On Wed, Sep 23 2015, Alexey Dobriyan wrote:
> I've sent kabs() before which didn't go in because it didn't work for
> INT_MAX et al
> (don't worry, this abs() doens't as well) but it is nicer that this
> version in other aspects
> (hopefully).
>
> [PATCH v2] Add kabs()
> http://marc.info/?l=linux-kernel&m=133518745522740&w=4

Perhaps:

+	(void)(_x)))))));						\

instead of:

+	_x))))));							\

at the end.  Since kabs makes no sense for unsigned types itâs best to
fail with compile-time error than to let user think that the call is
actually doing something.

Also, you donât need ({ â }) around the â_x < 0 ? -_x : _xâ expression,
do you?

-- 
Best regards,                                            _     _
.o. | Liege of Serenely Enlightened Majesty of         o' \,=./ `o
..o | Computer Science,  ããã âmina86â ãããããã  (o o)
ooo +--<mpn@xxxxxxxxxx>--<xmpp:mina86@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/