RE: [Patch V1 1/3] x86, mce: MCE log size not enough for high core parts

From: Luck, Tony
Date: Thu Sep 24 2015 - 15:00:55 EST


> If we get new ones logged in the meantime and userspace hasn't managed
> to consume and delete the present ones yet, we overwrite the oldest ones
> and set MCE_OVERFLOW like mce_log does now for mcelog. And that's no
> difference in functionality than what we have now.

Ummmm. No.

for (;;) {

/*
* When the buffer fills up discard new entries.
* Assume that the earlier errors are the more
* interesting ones:
*/
if (entry >= MCE_LOG_LEN) {
set_bit(MCE_OVERFLOW,
(unsigned long *)&mcelog.flags);
return;
}

-Tony