Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

From: Sudip Mukherjee
Date: Fri Sep 25 2015 - 09:42:24 EST


On Thu, Sep 24, 2015 at 02:58:31PM +0300, Tomi Valkeinen wrote:
>
> On 02/09/15 15:48, Sudip Mukherjee wrote:
>
<snip>
>
> Is there a public datasheet for the HW?
I could not find one in Silicon Motion website. I will try to find else
I can talk to them and keep it in my github. And can send you also if
you want.
>
> The driver as it is now is quite horrible. Huge tables of raw data,
> written directly to the registers. Lots of magic numbers all around.
> Even with a datasheet, presuming it's public and it contains all those
> values, the driver is rather unmaintainable.
>
> All those need to be sorted out for the DRM driver anyway, so maybe it's
> better to clean up the fb driver first.
Ok. I never looked at them to see how they can be made better. I will
see.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/