Re: [PATCH 07/17][UPDATE] mfd: qcom_rpm: Drop use of IRQF_NO_SUSPEND flag

From: Lee Jones
Date: Fri Sep 25 2015 - 12:08:36 EST


On Fri, 25 Sep 2015, Sudeep Holla wrote:

> The driver handles wakeup irq correctly using irq_set_irq_wake. There's
> no need to use IRQF_NO_SUSPEND while registering the interrupt.
>
> This patch removes the use of IRQF_NO_SUSPEND flag.
>
> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> ---
> drivers/mfd/qcom_rpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Updated version with the $subject fixed and Lee's ACK.

Applied, thanks.

> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 6afc9fabd94c..207a3bd68559 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -550,7 +550,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
> ret = devm_request_irq(&pdev->dev,
> irq_ack,
> qcom_rpm_ack_interrupt,
> - IRQF_TRIGGER_RISING | IRQF_NO_SUSPEND,
> + IRQF_TRIGGER_RISING,
> "qcom_rpm_ack",
> rpm);
> if (ret) {

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/