Re: [PATCH 1/1] PCI/MSI: X-Gene: Remove msi_controller assignment in X-Gene PCIe driver

From: Duc Dang
Date: Fri Sep 25 2015 - 20:12:46 EST


On Fri, Sep 25, 2015 at 4:34 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> On Fri, Sep 18, 2015 at 09:59:56AM +0100, Marc Zyngier wrote:
>> On Wed, 16 Sep 2015 17:31:40 -0700
>> Duc Dang <dhdang@xxxxxxx> wrote:
>>
>> > With commit 8d63bc7beaee ("PCI/MSI: pci-xgene-msi: Get rid of
>> > struct msi_controller"), it is no longer required to assign
>> > msi_controller for X-Gene PCIe host bridge to support MSI. This
>> > patch removes this unnecessary code and also helps avoid a warning
>> > message ("failed to enable MSI") during boot.
>> >
>> > Signed-off-by: Duc Dang <dhdang@xxxxxxx>
>> > Cc: Tanmay Inamdar <tinamdar@xxxxxxx>
>>
>> Acked-by: Marc Zyngier <marc.zyngier@xxxxxxx>
>
> I lost the original mail from Duc, but I applied this to pci/host-xgene for
> v4.4 with this changelog:

Thanks a lot, Bjorn.
>
> commit 00b9b91cb330e70b6bc571a9aa7175b4590ca452
> Author: Duc Dang <dhdang@xxxxxxx>
> Date: Wed Sep 16 17:31:40 2015 -0700
>
> PCI/MSI: xgene: Remove msi_controller assignment
>
> After 8d63bc7beaee ("PCI/MSI: pci-xgene-msi: Get rid of struct
> msi_controller"), it is no longer required to assign msi_controller for
> X-Gene PCIe host bridge to support MSI.
>
> Remove this unnecessary code. This also avoids a warning message ("failed
> to enable MSI") during boot.
>
> [bhelgaas: changelog]
> Signed-off-by: Duc Dang <dhdang@xxxxxxx>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Acked-by: Marc Zyngier <marc.zyngier@xxxxxxx>
> Cc: Tanmay Inamdar <tinamdar@xxxxxxx>

Regards,
Duc Dang.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/