Re: [PATCH] x86/signal: Deinline get_sigframe, save 240 bytes

[H. Peter Anvin]

This one makes me slightly nervous, because it isn't clear that these aren't potentially performance sensitive.

On September 28, 2015 5:23:57 AM PDT, Denys Vlasenko <dvlasenk@xxxxxxxxxx> wrote:
>This function compiles to 277 bytes of machine code and has 4
>callsites.
>
>Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
>CC: Ingo Molnar <mingo@xxxxxxxxxx>
>CC: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
>CC: "H. Peter Anvin" <hpa@xxxxxxxxx>
>CC: Borislav Petkov <bp@xxxxxxxxx>
>CC: Brian Gerst <brgerst@xxxxxxxxx>
>CC: x86@xxxxxxxxxx
>CC: linux-kernel@xxxxxxxxxxxxxxx
>---
> arch/x86/kernel/signal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
>index da52e6b..054a4d0 100644
>--- a/arch/x86/kernel/signal.c
>+++ b/arch/x86/kernel/signal.c
>@@ -196,7 +196,7 @@ static unsigned long align_sigframe(unsigned long
>sp)
> 	return sp;
> }
> 
>-static inline void __user *
>+static void __user *
>get_sigframe(struct k_sigaction *ka, struct pt_regs *regs, size_t
>frame_size,
> 	     void __user **fpstate)
> {

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/