Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver

From: Alexander Popov
Date: Mon Sep 28 2015 - 09:09:53 EST

Next message: Jacek Anaszewski: "[PATCH v2 05/12] leds: core: Add an internal led_set_brightness_nosleep function"
Previous message: Jacek Anaszewski: "[PATCH v2 07/12] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting"
In reply to: Timur Tabi: "Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver"
Next in thread: Timur Tabi: "Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello, Timur, thanks a lot for your review.
I'll fix all the issues you pointed at and return with v4.

The only question I have: why calling dma_unmap_single() from within
a spinlock is a bad practice?

Best regards,
Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Jacek Anaszewski: "[PATCH v2 05/12] leds: core: Add an internal led_set_brightness_nosleep function"
Previous message: Jacek Anaszewski: "[PATCH v2 07/12] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting"
In reply to: Timur Tabi: "Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver"
Next in thread: Timur Tabi: "Re: [PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]