Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64

From: Boris Ostrovsky
Date: Mon Sep 28 2015 - 10:05:14 EST


On 09/28/2015 09:59 AM, Julien Grall wrote:
Hi David,

On 28/09/15 14:52, David Vrabel wrote:
On 28/09/15 14:30, Julien Grall wrote:
The PCI support for Xen doesn't compile on ARM/ARM64 when
CONFIG_PCI_MMCONFIG=y:

drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or
directory
#include <asm/pci_x86.h>

Although, Xen is not currently involved in PCI management for ARM/ARM64.
There is plan to support it, but it would require some changes in Linux
side.

For now, introduce a new config options XEN_PCI which will be turned off
for ARM platform.
Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c
is, can you fix this by changing to #ifdef CONFIG_X86?
Well, it may be possible that we need this code for ARM/ARM64.

From the origin thread [1], it wasn't clear what is the correct
solution. So I think that disabling the Xen PCI code for now is the
right solution.

Note, that it's still possible to use PCI in DOM0 on ARM64 platform
without this code.

Regards,

[1] https://lkml.org/lkml/2015/8/6/510


Can we then implement Robert's proposals from that thread and have an arch function for pci_probe? It will be a nop on ARM. (I think that was the only problem here).

-boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/