Re: [PATCH 3/3] ARM: bcm2835: Add the auxiliary clocks to the device tree.

From: Eric Anholt
Date: Mon Sep 28 2015 - 15:26:56 EST

Stephen Warren <swarren@xxxxxxxxxxxxx> writes:

> On 09/10/2015 03:22 PM, Eric Anholt wrote:
>> These will be used for enabling UART1, SPI1, and SPI2.
>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
>> + aux_clocks: aux-clocks@0x7e215004 {
>> + compatible = "brcm,bcm2835-aux-clock";
>> + #clock-cells = <1>;
>> + reg = <0x7e215004 0x4>;
> Actually, I take back the ack on this patch. This HW module has two
> registers. The reg property should include both of those registers so
> that if SW needs to start using the other register at some time in the
> future, the entire set of registers is already represented in DT.

If I changed it to "reg = <0x7e215000 0x8>" and use a #define for the
clock register offset in patch 2/3, would I then have your ack?

Attachment: signature.asc
Description: PGP signature