RE: [PATCH V10 0/8] Freq/CPU%/CORE_BUSY% support

[Liang, Kan]

Hi Arnaldo and Jirka,

Any comments for the V10 patch set?

Thanks,
Kan



> 
> From: Kan Liang <kan.liang@xxxxxxxxx>
> 
> This patch set supports per-sample freq/CPU%/CORE_BUSY% print in perf
> report.
> For printing these information, the perf.data file must have been obtained
> by group read and using special events cycles, ref-cycles, msr/tsc/,
> msr/aperf/ or msr/mperf/.
> 
>  - Freq (MHz): The frequency during the sample interval. Needs cycles
>    ref-cycles event.
>  - CPU%: CPU utilization during the sample interval. Needs ref-cycles and
>    msr/tsc/ events.
>  - CORE_BUSY%: actual percent performance (APERF/MPERF%) during the
>    sample interval. Needs msr/aperf/ and msr/mperf/ events.
> 
> Here is an example:
> 
> $ perf record --perf-freq ~/tchain_edit
> 
> $ perf report --stdio --perf-freq
> 
>                                  Overhead   FREQ MHz   CPU%  CORE_BUSY%
> Command      Shared Object     Symbol
>  ........................................  .........  .....  ..........
> ...........  ................  ......................
> 
>     99.54%  99.54%  99.53%  99.53%  99.53%       2301     96         99
> tchain_edit  tchain_edit       [.] f3
>      0.20%   0.20%   0.20%   0.20%   0.20%       2301     98         99
> tchain_edit  tchain_edit       [.] f2
>      0.05%   0.05%   0.05%   0.05%   0.05%       2300     98         99
> tchain_edit  [kernel.vmlinux]  [k] read_tsc
> 
> Changes since V1:
>  - Save cpu max freq to header when recording
>  - Read cpu max freq and msr type from header when reporting
> 
> Changes since V2:
>  - Introduce generic FEAT for CPU related data stored
>  - Make cpu max freq and msr type part of perf_session_env
>  - rename cpu_u to cpu_util
>  - Don't save sample value in perf_sample and discards new iterator.
>    Calculating the freq_perf_info in add_entry_cb callback
>  - Introduce symbol_conf.freq_perf_type for related hpp column visibility
> 
> Changes since V3:
>  - add a identifier 'tag' for CPU attributes, max frequency.
>  - add backpointers to evlist for env, and evsel for evlist.
>  - Use bitmask for freq_perf_type
>  - Replace macros by functions to caculate freq, cpu_util and core_busy
>  - Move all caculation codes under symbol_conf.show_freq_perf condition.
> 
> Changes since V4:
>  - Store cpu attributes id as tag and more readable cpu_attr
> 
> Changes since V5:
>  - Rename freq to max_freq and use it
>  - Add a loop in process_cpu_attributes to facility future extension
> 
> Changes since V6:
>  - Split rename perf_session_env and add backpointer to evlist patches
> 
> Changes since V7:
>  - Introduce --freq-perf option for perf record
>  - Factor out fix for dump_sample
> 
> Changes since V8:
>  - Rename --show-freq-perf to --freq-perf
>  - --freq-perf option imply --group
> 
> Changes since V9:
>  - Rebase on commit d71b0ad8d309
>  - Error handling for CPU attributes header write and process
>  - Rewrite the description for --perf-freq in perf record
>  - Add perf_freq_t in perf_sample to store frequency and performance
> data.
>  - rename --freq-perf to --perf-freq
>  - The last patch is split into three patches (6/8 only show leader value in
> hpp__fmt,
>    7/8 HPP__SINGLE_PRINT_FNS support and 8/8 perf report --perf-freq
> support)
> 
> Kan Liang (8):
>   perf,tools: introduce generic FEAT for CPU attributes
>   perf,record: introduce --perf-freq option
>   perf,tools: caculate freq per sample
>   perf,tools: Dump per-sample freq/CPU%/CORE_BUSY% in report -D
>   perf,tools: caculate and save freq/CPU%/CORE_BUSY% in he_stat
>   perf,tools: only show leader's value in hpp__fmt
>   perf,tools: Introduce HPP__SINGLE_PRINT_FNS support
>   perf,tools: Show freq/CPU%/CORE_BUSY% in perf report by --perf-freq
> 
>  tools/perf/Documentation/perf-record.txt |  8 ++++
> tools/perf/Documentation/perf-report.txt | 12 ++++++
>  tools/perf/builtin-record.c              | 39 ++++++++++++++++++-
>  tools/perf/builtin-report.c              | 41 ++++++++++++++++++++
>  tools/perf/ui/hist.c                     | 66 +++++++++++++++++++++++++++++---
>  tools/perf/util/env.h                    | 11 ++++++
>  tools/perf/util/event.h                  | 13 +++++++
>  tools/perf/util/header.c                 | 62
> ++++++++++++++++++++++++++++++
>  tools/perf/util/header.h                 |  1 +
>  tools/perf/util/hist.h                   |  3 ++
>  tools/perf/util/session.c                | 44 +++++++++++++++++++--
>  tools/perf/util/session.h                | 52 +++++++++++++++++++++++++
>  tools/perf/util/sort.c                   |  3 ++
>  tools/perf/util/sort.h                   |  3 ++
>  tools/perf/util/symbol.h                 | 12 +++++-
>  15 files changed, 360 insertions(+), 10 deletions(-)
> 
> --
> 1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/