Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle

From: Rafael J. Wysocki
Date: Mon Sep 28 2015 - 16:09:41 EST


On Mon, Sep 28, 2015 at 10:05 PM, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> Hi,
>
> On Mon, Sep 28, 2015 at 7:56 PM, Chen, Yu C <yu.c.chen@xxxxxxxxx> wrote:

[cut]

>>> > Because the name of acpi_irq is already used by acpi irq handler at
>>> > drivers/acpi/osl.c:
>>> > request_irq(irq, acpi_irq, IRQF_SHARED, "acpi", acpi_irq)
>>>
>>> Ah, this is the name of the handler. I forgot about that, sorry.
>>>
>>> Well, it might be worth renaming the handler to something like
>>> acpi_interrupt(), then.
>> OK, will rewrite the patch, Thanks!
>
> Alternatively, you can call the new variable acpi_sci_irq.

BTW, please CC ACPI-related patches to linux-acpi too.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/