Re: [PATCH] mtd: nand: denali: max_banks calculation changed in revision 5.1

From: Brian Norris
Date: Tue Sep 29 2015 - 15:57:02 EST


On Tue, Sep 29, 2015 at 11:31:21AM -0700, Brian Norris wrote:
> On Tue, Sep 29, 2015 at 10:01:10AM -0500, Graham Moore wrote:
> > On 07/21/2015 09:39 AM, Graham Moore wrote:
> > >diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> > >index 870c7fc..a98b41e 100644
> > >--- a/drivers/mtd/nand/denali.h
> > >+++ b/drivers/mtd/nand/denali.h
> > >@@ -178,6 +178,8 @@
> > >
> > > #define REVISION 0x370
> > > #define REVISION__VALUE 0xffff
> > >+#define MAKE_COMPARABLE_REVISION(x) swab16(x & REVISION__VALUE)
>
> It's probably best to add parentheses around the 'x'.
>
> > >+#define REVISION_5_1 0x00000501
> > >
> > > #define ONFI_DEVICE_FEATURES 0x380
> > > #define ONFI_DEVICE_FEATURES__VALUE 0x003f
> > >
> >
>
> I can fix that up and apply, if no objections.

Pushed to l2-mtd.git with that fixup.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/