Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

[Chandra Gorentla]

On Tue, Sep 29, 2015 at 05:31:53AM +0300, Dan Carpenter wrote:
> On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote:
> >  - The message queue is replaced with standard Linux linked list
> >  - kmem_cache is used for list members
> >  - A check for return value of receive method is added
> >  - GFP_ATOMIC is changed to GFP_KERNEL
> >  - A few other related minor changes
> 
> These should be listed and explained.
OK.  I will try to send seperate patches.
> 
> >  
> >  	while (1) {
> > -		wilc_mq_recv(&gMsgQHostIF, &msg, sizeof(struct host_if_msg), &u32Ret);
> > +		ret = wilc_mq_recv(&gMsgQHostIF, &msg,
> > +					sizeof(struct host_if_msg), &u32Ret);
> > +		if (ret)
> > +			continue;
> > +
> 
> I asked before if this was a forever loop and never got a response.
> Also what does this have to do with list macros?
The only exit condition of this loop is to receive a message
'HOST_IF_MSG_EXIT'.  If this check is not there and 'wilc_mq_recv'
returns an error, the switch case below it will be executed for
the previously received message.

I will send this change in a different patch.
> 
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/