Re: [PATCH RFC] IB/mad: remove obsolete snoop interface

From: Hal Rosenstock
Date: Wed Sep 30 2015 - 08:54:56 EST


On 9/30/2015 2:01 AM, ira.weiny@xxxxxxxxx wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> This interface has no current users and is obsolete.

There are no in tree users of this but there is Sean's madeye tool
(which is out of tree). This is still a useful debug tool for MADs.

> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> ---
>
> This has undergone a medium level of testing. I have run it against
> mlx4, qib, and OPA hardware and it does not seem to cause any regressions.
>
> drivers/infiniband/core/mad.c | 226 +------------------------------------
> drivers/infiniband/core/mad_priv.h | 13 ---
> 2 files changed, 5 insertions(+), 234 deletions(-)

There are also snoop changes needed in include/rdma/ib_mad.h.

Is it correct to assume that OPA_CAP_MASK3_IsSnoopSupported in
opa_port_info.h is not related to this ?

-- Hal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/