Re: [PATCH v2 5/6] tty: serial: msm: Add RX DMA support

[Mark Rutland]

On Wed, Sep 30, 2015 at 01:08:25PM +0100, Ivan T. Ivanov wrote:
> Add receive DMA support for UARTDM type of controllers.
> 
> Tested on APQ8064, which have UARTDM v1.3 and ADM DMA engine
> and APQ8016, which have UARTDM v1.4 and BAM DMA engine.
> 
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/serial/qcom,msm-uartdm.txt |   3 +
>  drivers/tty/serial/msm_serial.c                    | 232 ++++++++++++++++++++-
>  drivers/tty/serial/msm_serial.h                    |   4 +
>  3 files changed, 236 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt b/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
> index a600023d9ec1..182777fac9a2 100644
> --- a/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
> +++ b/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
> @@ -29,6 +29,9 @@ Optional properties:
>  - qcom,tx-crci: Identificator <u32> for Client Rate Control Interface to be
>             used with TX DMA channel. Required when using DMA for transmission
>             with UARTDM v1.3 and bellow.
> +- qcom,rx-crci: Identificator <u32> for Client Rate Control Interface to be
> +           used with RX DMA channel. Required when using DMA for reception
> +           with UARTDM v1.3 and bellow.

My comments on qcom,tx-crci apply to qcom,rx-crci too.

This does not deel like it belongs in the UART binding and/or driver.

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/