Re: [PATCH 2/2] clocksource/drivers/keystone: Fix bad NO_IRQ usage

From: santosh shilimkar
Date: Wed Sep 30 2015 - 11:27:21 EST

On 9/30/2015 3:08 AM, Daniel Lezcano wrote:
The current code assumes the 'irq_of_parse_and_map' will return NO_IRQ in case
of failure. Unfortunately, the NO_IRQ is not consistent across the different
architectures and we must not rely on it.

NO_IRQ is equal to '-1' on ARM and 'irq_of_parse_and_map' returns '0' in case
of an error. Hence, the latter won't be detected and will lead to a crash.

Fix this by just checking 'irq' is different from zero.

Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
drivers/clocksource/timer-keystone.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Santosh Shilimkar <ssantosh@xxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at