Re: [RFC 0/4] reduce pid_namespace footprint when not configured

[Rasmus Villemoes]

On Wed, Sep 30 2015, ebiederm@xxxxxxxxxxxx (Eric W. Biederman) wrote:

> Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> writes:
>
>> A few suggestions for reducing the footprint of pid namespaces when
>> CONFIG_PID_NS=n. The savings are admittedly not huge:
>>
>> $ scripts/bloat-o-meter /tmp/vmlinux.master vmlinux
>> add/remove: 0/7 grow/shrink: 30/25 up/down: 368/-1032 (-664)
>
> #ifdefs in C files.
> More code to maintain.
> Very minor savings.
>
> I don't think it is worth the pain.  If anything I would prefer to
> remove CONFIG_PID_NS.  The CONFIG_PID_NS ifdef really is about keeping
> from exposing people to the feature tha don't use it more than it is
> about size reduction.
>
> Or do you have a case where this makes the difference between a usable
> kernel and a kernel that is not?

No, it was mostly a small tinification effort, and we'd presumably also
save a few cycles on thread creation, but not anything measurable.

Rasmus

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/