Re: [PATCH v2 2/8] spi: imx: replace fixed timeout with calculated one

From: Bondarenko, Anton
Date: Wed Sep 30 2015 - 20:10:43 EST


On 30.09.2015 10:31, Robin Gong wrote:
> On Fri, Sep 25, 2015 at 07:57:09PM +0200, Anton Bondarenko wrote:
>> @@ -957,8 +988,10 @@ static int spi_imx_dma_transfer(struct spi_imx_data *spi_imx,
>> dmaengine_terminate_all(master->dma_tx);
>> dmaengine_terminate_all(master->dma_rx);
>> } else {
>> + transfer_timeout = spi_imx_calculate_timeout(spi_imx,
>> + spi_imx->wml * 2);
> *2 again here? Although spi_imx_calculate_timeout has double it.
WIll be fixed in V3
>> timeout = wait_for_completion_timeout(
>> - &spi_imx->dma_rx_completion, IMX_DMA_TIMEOUT);
>> + &spi_imx->dma_rx_completion, transfer_timeout);
>> if (!timeout) {
>> pr_warn("%s %s: I/O Error in DMA RX\n",
>> dev_driver_string(&master->dev),
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/