Re: [PATCH 2/3] leds: add debugfs to device trigger
From: Jacek Anaszewski
Date: Thu Oct 01 2015 - 03:36:11 EST
On 09/30/2015 05:47 PM, Maciek Borzecki wrote:
On 09/30 16:08, Jacek Anaszewski wrote:
Hi Maciek,
Please test your solution thoroughly before submitting
the next version. Writing to debugfs register attribute
fails due to lack of proper copying from user memory,
which makes testing impossible.
Hi, thanks for the comment. Indeed, I noticed the problem just after
sending the patch. Surprisingly this didn't fail on iMX6 for some
reason.
Aside from the __user access problem, is the approach, in general, ok for
you or would you suggest that I changed something?
At first glance the feature looks nice. I'll be able to say more
after testing working version.
--
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/