Re: [RFC v2 4/7] powerpc: atomic: Implement xchg_* and atomic{,64}_xchg_* variants
From: Peter Zijlstra
Date: Thu Oct 01 2015 - 08:25:00 EST
On Wed, Sep 16, 2015 at 11:49:32PM +0800, Boqun Feng wrote:
> Implement xchg_relaxed and define atomic{,64}_xchg_* as xchg_relaxed,
> based on these _relaxed variants, release/acquire variants can be built.
>
> Note that xchg_relaxed and atomic_{,64}_xchg_relaxed are not compiler
> barriers.
Hmm, and I note your previous patch creating the regular _relaxed
thingies also removes the memory clobber.
And looking at the ARM _relaxed patch from Will, I see their _relaxed
ops are also not a compiler barrier.
I must say I'm somewhat surprised by this level of relaxation, I had
expected to only loose SMP barriers, not the program order ones.
Is there a good argument for this?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/