Re: [PATCH] thermal: exynos: fix register read in TMU

[Krzysztof Kozlowski]

2015-10-01 20:39 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>:
> The value of emul_con was getting overwritten if the selected soc is
> SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
> register in the case of SOC_ARCH_EXYNOS5260.

How the value is overwritten if the soc is Exynos5260? I can't see it
(although the "else if" is still more obvious than "if" but how does
the description match the code?).

Best regards,
Krzysztof

>
> Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
> ---
>  drivers/thermal/samsung/exynos_tmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index 0bae8cc..ca920b0 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data,
>
>         if (data->soc == SOC_ARCH_EXYNOS5260)
>                 emul_con = EXYNOS5260_EMUL_CON;
> -       if (data->soc == SOC_ARCH_EXYNOS5433)
> +       else if (data->soc == SOC_ARCH_EXYNOS5433)
>                 emul_con = EXYNOS5433_TMU_EMUL_CON;
>         else if (data->soc == SOC_ARCH_EXYNOS7)
>                 emul_con = EXYNOS7_TMU_REG_EMUL_CON;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/