Re: CRIS v32: leftover references on ETRAX_VIRTUAL_GPIO

[Jesper Nilsson]

On Fri, Oct 02, 2015 at 08:57:22AM +0200, Valentin Rothberg wrote:
> Hi Rabin,

Hi!

> your commit ("CRIS v32: remove old GPIO and LEDs code") is in today's
> linux-next tree (i.e., 20151002).  Among other Kconfig options, the
> commit removes ETRAX_VIRTUAL_GPIO but leaves the following references in
> the code:
> 
> 0 arch/cris/arch-v32/kernel/setup.c       132 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO
> 1 arch/cris/arch-v32/kernel/setup.c       149 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO
> 2 arch/cris/arch-v32/mach-fs/Kconfig      197 depends on ETRAX_VIRTUAL_GPIO
> 3 arch/cris/arch-v32/mach-fs/Kconfig      208 depends on ETRAX_VIRTUAL_GPIO
> 4 arch/cris/include/uapi/asm/etraxgpio.h   59 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO
> 5 arch/cris/include/uapi/asm/etraxgpio.h   74 #ifdef CONFIG_ETRAX_VIRTUAL_GPIO
> 
> Is it intentional or just an accident?

I'm guessing it's an accident, I did have some trouble applying that
particular patch and I had to verify the patch by hand, but I might
have made a mistake and removed something that Rabin didn't remove.
(Since I knew this symbol was tightly connected to the CRIS gpio)

Anyways, I'll roll a patch for removing them, thanks for the heads-up!

/Jesper

> I found the issue with scripts/checkkconfigsymbols.py.
> 
> Kind regards,
>  Valentin

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/