[PATCH 16/18] Input: elan_i2c - simplify function return logic

From: Javier Martinez Canillas
Date: Fri Oct 02 2015 - 09:41:32 EST


The invoked function already returns zero on success or a negative
errno code so there is no need to open code the logic in the caller.

This also fixes the following make coccicheck warning:

drivers/input/mouse/elan_i2c_smbus.c:402:1-6: WARNING: end returns can be simplified

Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
---

drivers/input/mouse/elan_i2c_smbus.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/input/mouse/elan_i2c_smbus.c b/drivers/input/mouse/elan_i2c_smbus.c
index cb6aecbc1dc2..e5b0adfac3d0 100644
--- a/drivers/input/mouse/elan_i2c_smbus.c
+++ b/drivers/input/mouse/elan_i2c_smbus.c
@@ -399,11 +399,7 @@ static int elan_smbus_prepare_fw_update(struct i2c_client *client)
return error;

/* Reset IC */
- error = elan_smbus_iap_reset(client);
- if (error)
- return error;
-
- return 0;
+ return elan_smbus_iap_reset(client);
}


--
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/