Re: [PATCH 00/18] Input - Fix make coccicheck warnings

[Dmitry Torokhov]

Hi Javier,

On Fri, Oct 02, 2015 at 03:40:11PM +0200, Javier Martinez Canillas wrote:
> Hello Dmitry,
> 
> This series contains trivial patches with fixes to different warnings
> reported by make coccichek M=drivers/input.
> 
> The patches don't contain functional changes but makes the functions
> simpler and removes unnecessary lines of code.

I disagree with some "simplify function return logic" patches: when
there are several actions that may fail I prefer explicit:

	error = actionN();
	if (error)
		return error;

	return 0;

even on the last one as it keep with the code flow and makes it easier
to move stuff around.

Please consider patches that not explicitly replied to as applied a
dropped.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/