[PATCH v4 2/5] PCI: generic: Only fixup irqs for bus we are creating.

From: David Daney
Date: Fri Oct 02 2015 - 14:46:18 EST


From: David Daney <david.daney@xxxxxxxxxx>

If we create multiple buses with pci-host-generic, or there are buses
created by other drivers, we don't want to call pci_fixup_irqs() which
operates on all devices, not just the devices on the bus being added.
The consequence is that either the fixups are done more than once, or
in some cases incorrect fixups could be applied.

Call pci_bus_fixup_irqs() instead of pci_fixup_irqs().

Acked-by: Will Deacon <will.deacon@xxxxxxx>
Signed-off-by: David Daney <david.daney@xxxxxxxxxx>
---
No change from v2.

drivers/pci/host/pci-host-generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pci-host-generic.c b/drivers/pci/host/pci-host-generic.c
index 265dd25..9e9f1c3 100644
--- a/drivers/pci/host/pci-host-generic.c
+++ b/drivers/pci/host/pci-host-generic.c
@@ -262,7 +262,7 @@ static int gen_pci_probe(struct platform_device *pdev)
return -ENODEV;
}

- pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci);
+ pci_bus_fixup_irqs(bus, pci_common_swizzle, of_irq_parse_and_map_pci);

if (!pci_has_flag(PCI_PROBE_ONLY)) {
pci_bus_size_bridges(bus);
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/