Re: [RFC v2 07/18] kthread: Allow to cancel kthread work

From: Tejun Heo
Date: Fri Oct 02 2015 - 15:25:04 EST


Hello,

On Fri, Oct 02, 2015 at 05:43:36PM +0200, Petr Mladek wrote:
> IMHO, we need both locks. The worker manipulates more works and
> need its own lock. We need work-specific lock because the work
> might be assigned to different workers and we need to be sure
> that the operations are really serialized, e.g. queuing.

I don't think we need per-work lock. Do we have such usage in kernel
at all? If you're worried, let the first queueing record the worker
and trigger warning if someone tries to queue it anywhere else. This
doesn't need to be full-on general like workqueue. Let's make
reasonable trade-offs where possible.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/