Re: [PATCH] ver_linux: module-init-tools.patch

[Alexander Kapshuk]

On Fri, Oct 2, 2015 at 10:45 PM, Jim Davis <jim.epost@xxxxxxxxx> wrote:
> On Fri, Oct 2, 2015 at 12:35 PM, Jim Davis <jim.epost@xxxxxxxxx> wrote:
>> On Fri, Oct 2, 2015 at 12:03 PM, Alexander Kapshuk
>>
>>>>> +depmod=`whereis depmod | awk '{print $2}'`
>>>>
>
>> I suspect it'll be hard to come up with something that's 100%
>> foolproof and respects user's choices.  Sticking with searching the
>> user's $PATH at least won't lead to surprises about which program is
>> being run...
>
> Though looking back at your patch, what might work is to look first
> for depmod in the user's $PATH and then try whereis only if that
> fails.  I'm not convinced that's much better than just searching
> $PATH, but that at least would go with the user's preference first.
>
> --
> Jim

Seems like the way to go. Thanks.

I'll resubmit this and the other patches tomorrow with this
consideration in mind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/