Re: [PATCH v2 5/7] 9p: xattr simplifications

[Christoph Hellwig]

On Tue, Sep 22, 2015 at 02:26:50PM +0200, Andreas Gruenbacher wrote:
>  
> +/**
> + * xattr_full_name  -  Compute full attribute name from suffix
> + *

Missing argument descriptions for a kdoc comment.

> +const char *xattr_full_name(const struct xattr_handler *handler,
> +			    const char *name)
> +{
> +	size_t prefix_len = strlen(handler->prefix);
> +
> +	/* assert(memcmp(name - prefix_len, handler->prefix, prefix_len) == 0); */

This either should be a real WARN_ON or go away.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/