Re: [PATCH 2/2] drivers: staging: wilc1000: Call kfree only for error cases
From: Greg KH
Date: Sun Oct 04 2015 - 06:10:26 EST
On Sun, Oct 04, 2015 at 12:16:31PM +0300, Dan Carpenter wrote:
> On Sun, Oct 04, 2015 at 09:44:57AM +0100, Greg KH wrote:
> > Aren't you now leaking memory as you aren't freeing pstrMessage and the
> > buffer on the "normal" return path?
>
> It's supposed to. It's a bug fix. I explained to him in the first
> version that his changelog sucks.
Ok, well, it still sucks :)
And it's out of my queue, so I'll wait for the next spin of this
series...
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/