Re: [PATCH] drivers: Update help for firmware loading options

From: Greg KH
Date: Sun Oct 04 2015 - 15:14:26 EST


On Sun, Aug 09, 2015 at 05:01:16PM -0500, Eric Biggers wrote:
> Update the help text to account for the fact that the kernel can now load
> firmware directly from the filesystem. Also clarify how the FW_LOADER
> option works.
>
> Signed-off-by: Eric Biggers <ebiggers3@xxxxxxxxx>
> ---
> drivers/base/Kconfig | 33 +++++++++++++++++++++------------
> 1 file changed, 21 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index 98504ec..2150f6c 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -78,12 +78,21 @@ config PREVENT_FIRMWARE_BUILD
> If unsure, say Y here.
>
> config FW_LOADER
> - tristate "Userspace firmware loading support" if EXPERT
> + tristate "Firmware loading support" if EXPERT

Are you sure? I think this should stay as "Userspace..." as that is
what it does, right?

Turning it off should only drop the userspace callouts, it shouldn't
stop the kernel from loading firmware from the filesystem all on its own
with no help.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/