Re: [PATCH 3/3] mm/nommu: drop unlikely behind BUG_ON()

[Davidlohr Bueso]

On Sun, 04 Oct 2015, Leon Romanovsky wrote:

> On Sun, Oct 4, 2015 at 9:18 AM, Geliang Tang <geliangtang@xxxxxxx> wrote:
> > BUG_ON() already contain an unlikely compiler flag. Drop it.
> It is not the case if CONFIG_BUG and HAVE_ARCH_BUG_ON are not set.

Yeah, but that's like the 1% of the cases -- and those probably don't even care
about the branch prediction (I could be wrong). So overall I like getting rid of
explicit BUG_ON(unlikely(... calls. In fact there's a _reason_ why there are so
few of them in the kernel.

Thanks,
Davidlohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/