Re: [PATCH v5 1/2] PM / sleep: Go direct_complete if driver has no callbacks

[Pavel Machek]

On Mon 2015-10-05 10:25:45, Tomeu Vizoso wrote:
> On 4 October 2015 at 17:16, Pavel Machek <pavel@xxxxxx> wrote:
> > On Tue 2015-09-29 14:29:19, Tomeu Vizoso wrote:
> >> If a suitable prepare callback cannot be found for a given device and
> >> its driver has no PM callbacks at all, assume that it can go direct to
> >> complete when the system goes to sleep.
> >>
> >> The reason for this is that there's lots of devices in a system that do
> >> no PM at all and there's no reason for them to prevent their ancestors
> >> to do direct_complete if they can support it.
> >
> > Dunno. This sounds like asking for trouble. Even if most devices can handle
> > this, is not this bound to introduce some bugs?
> 
> Hi Pavel,
> 
> in which situations do you think that this could be problematic?

Well.. driver with no PM callbacks probably works "by accident", and now you are changing
its environment. Do you have explanation why it will not break?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/