Re: [PATCH 1/2] scsi: move Additional Sense Codes to separate file

[Bart Van Assche]

On 10/05/15 02:26, Rasmus Villemoes wrote:
> -	{0x041A, "Logical unit not ready, start stop unit command in "
> -	 "progress"},
> -	{0x041B, "Logical unit not ready, sanitize in progress"},
> -	{0x041C, "Logical unit not ready, additional power use not yet "
> -	 "granted"},

Please convert these multi-line strings into single line string 
constants such that users can look up these easily with grep.

> +
> +SENSE_CODE(0, NULL)

The above looks confusing to me. Please leave this out and add { 0, NULL 
} at the end of the additional[] array instead.

Thanks,

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/