Re: [PATCH] iio: mxs-lradc: Fix temperature offset

[Stefan Wahren]

Hi,

> Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> hat am 6. Oktober
> 2015 um 16:22 geschrieben:
>
>
> 0Â Kelvin is actually â273.15ÂC, not -272.15ÂC. Fix the temperature offset.
>
> Reported-by: Janusz UÅycki <j.uzycki@xxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c
> b/drivers/staging/iio/adc/mxs-lradc.c
> index 3f7715c9968b..67bfa54c4fb1 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -916,10 +916,10 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
> if (chan->type == IIO_TEMP) {
> /* The calculated value from the ADC is in Kelvin, we
> * want Celsius for hwmon so the offset is
> - * -272.15 * scale
> + * -273.15 * scale
> */
> - *val = -1075;
> - *val2 = 691699;
> + *val = -1079;
> + *val2 = 644268;
>

i think it would be nice to break down the calculation of these magic values in
a second patch.

Regards
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/