Re: [PATCH 1/2] ASoC: rockchip: i2s: add 8 channels capture and lrck-mode support

From: Mark Brown
Date: Wed Oct 07 2015 - 05:29:16 EST


On Wed, Oct 07, 2015 at 04:01:38PM +0800, sugar wrote:
> å 10/1/2015 02:46, Mark Brown åé:

> >What makes you say that the symmetric_rates flag can't be used to cover
> >this case? What you describe above is hte normal reason for needing to
> >enforce symmetric_rates. The driver should be able to check if the flag
> >has been set just as well as the core is.

> Got it, How about the following modify?

> if (dai->symmetric_rates)
> regmap_update_bits(i2s->regmap, I2S_CKR,
> I2S_CKR_TRCM_MASK,
> I2S_CKR_TRCM(val));

Yes, something like that. You'll need to check both links in the DAI
and the DAI link itself rather than just your own DAI but we should have
a helper function for that - I'll add one, look out for a patch shortly.

Attachment: signature.asc
Description: Digital signature