Re: [PATCH] PM / OPP: fix debugfs files for 64-bit

From: Greg Kroah-Hartman
Date: Wed Oct 07 2015 - 07:08:07 EST


On Wed, Oct 07, 2015 at 04:33:02PM +0530, Viresh Kumar wrote:
> On 07-10-15, 16:29, Viresh Kumar wrote:
> > What about adding something like debugfs_create_unsigned_long() for
> > such cases?
>
> And that can be as simple (or ugly, not sure if its buggy) as:
>
> debugfs_create_unsigned_long()
> {
> if (sizeof(unsigned long) == sizeof(u32))
> return debugfs_create_u32();
> if (sizeof(unsigned long) == sizeof(u64))
> return debugfs_create_u64();
>
> return -EINVAL;
> }

Why would you be wanting to create a "unsigned long" as an api anyway?
Just force it to be u64 all the time, can't you do that?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/