Re: [PATCH] misc: eeprom: at25: add Cypress FRAM functionality

From: kbuild test robot
Date: Wed Oct 07 2015 - 07:39:41 EST

Next message: Previous message:
In reply to:
Next in thread: Messages sorted by:
Hi Jiri,

[auto build test WARNING on v4.3-rc4 --
config: i386-randconfig-s1-201540 (attached reproduce:
# save the attached .config to make ARCH=i386

Note: it may well be a FALSE warning. FWIW .config.gz< Description: Binary data href="04635.html"> Andrey Ryabinin: "[PATCH v2] lockd: get rid of reference-counted NSM RPC clients" Prarit Bhargava: "Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch" kbuild test robot: "Re: [PATCH] misc: eeprom: at25: add Cypress FRAM functionality" href="04684.html"> kbuild test robot: "Re: [PATCH] misc: eeprom: at25: add Cypress FRAM functionality" href="date.html#04634">[ date ] [ thread ] [ subject ] [ author ] if it's inappropriate base, please ignore]
as .config)
linux build tree
you are at least aware of it now.
/Better_Uninitialized_Warnings">http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
> 'at25_fw_to_chip':
passing argument 3 of 'device_property_read_string' from incompatible pointer type [-Wincompatible-pointer-types]
&name);
^
5.c:22:0:
expected 'const char **' but argument is of type 'char **'
device *dev, const char *propname,
'at25_probe':
warning: 'addrlen' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 2015-10-07 395 int is_fram)
2012-08-22 396 {
2012-08-22 397 u32 val;
2015-10-07 398 char *name;
2012-08-22 399
2012-08-22 400 memset(chip, 0, sizeof(*chip));
2015-10-07 @401 device_property_read_string(dev, "name", &name);
2015-10-07 402 strncpy(chip->name, name, sizeof(chip->name));
2015-10-07 403
2015-10-07 404 if (is_fram) {
2015-10-07 405 if (device_property_present(dev, "read-only"))
2015-10-07 406 chip->flags |= EE_READONLY;
2015-10-07 407 return 0;
2015-10-07 408 }
2012-08-22 409
2014-10-21 410 if (device_property_read_u32(dev, "size", &val) == 0 ||
2014-10-21 411 device_property_read_u32(dev, "at25,byte-len", &val) == 0) {
2012-08-22 412 chip->byte_len = val;
2012-08-22 413 } else {
2012-08-22 414 dev_err(dev, "Error: missing \"size\" property\n");
2012-08-22 415 return -ENODEV;
2012-08-22 416 }
2012-08-22 417
2014-10-21 418 if (device_property_read_u32(dev, "pagesize", &val) == 0 ||
2014-10-21 419 device_property_read_u32(dev, "at25,page-size", &val) == 0) {
2012-08-22 420 chip->page_size = (u16)val;
2012-08-22 421 } else {
2012-08-22 422 dev_err(dev, "Error: missing \"pagesize\" property\n");
2012-08-22 423 return -ENODEV;
2012-08-22 424 }
2012-08-22 425
2014-10-21 426 if (device_property_read_u32(dev, "at25,addr-mode", &val) == 0) {
2012-08-22 427 chip->flags = (u16)val;
2012-08-22 428 } else {
2014-10-21 429 if (device_property_read_u32(dev, "address-width", &val)) {
2012-08-22 430 dev_err(dev,
2012-08-22 431 "Error: missing \"address-width\" property\n");
2012-08-22 432 return -ENODEV;
2012-08-22 433 }
2012-08-22 434 switch (val) {
2012-08-22 435 case 8:
2012-08-22 436 chip->flags |= EE_ADDR1;
2012-08-22 437 break;
2012-08-22 438 case 16:
2012-08-22 439 chip->flags |= EE_ADDR2;
2012-08-22 440 break;
2012-08-22 441 case 24:
2012-08-22 442 chip->flags |= EE_ADDR3;
2012-08-22 443 break;
2012-08-22 444 default:
2012-08-22 445 dev_err(dev,
2012-08-22 446 "Error: bad \"address-width\" property: %u\n",
2012-08-22 447 val);
2012-08-22 448 return -ENODEV;
2012-08-22 449 }
2014-10-21 450 if (device_property_present(dev, "read-only"))
2012-08-22 451 chip->flags |= EE_READONLY;
2012-08-22 452 }
2012-08-22 453 return 0;
2012-08-22 454 }
2012-08-22 455
2015-10-07 456 static const struct of_device_id at25_of_match[] = {
2015-10-07 457 { .compatible = "atmel,at25", .data = (const void *)IS_EEPROM },
2015-10-07 458 { .compatible = "cypress,fm25", .data = (const void *)IS_FRAM },
2015-10-07 459 { }
2015-10-07 460 };
2015-10-07 461 MODULE_DEVICE_TABLE(of, at25_of_match);
2015-10-07 462
2007-02-12 463 static int at25_probe(struct spi_device *spi)
2007-02-12 464 {
2007-02-12 465 struct at25_data *at25 = NULL;
Pereira da Silva 2012-06-14 466 struct spi_eeprom chip;
2007-02-12 467 int err;
2007-02-12 468 int sr;
2007-02-12 469 int addrlen;
2015-10-07 470 char id[FM25_ID_LEN];
2015-10-07 471 const struct of_device_id *match;
2015-10-07 472 int is_fram = 0;
2015-10-07 473
2015-10-07 474 match = of_match_device(of_match_ptr(at25_of_match), &spi->dev);
2015-10-07 475 if (match)
2015-10-07 476 is_fram = (int)(uintptr_t)match->data;
2007-02-12 477
2007-02-12 478 /* Chip description */
Pereira da Silva 2012-06-14 479 if (!spi->dev.platform_data) {
2015-10-07 480 err = at25_fw_to_chip(&spi->dev, &chip, is_fram);
2012-08-22 481 if (err)
2013-05-28 482 return err;
Pereira da Silva 2012-06-14 483 } else
Pereira da Silva 2012-06-14 484 chip = *(struct spi_eeprom *)spi->dev.platform_data;
2007-02-12 485
2007-02-12 486 /* For now we only support 8/16/24 bit addressing */
2015-10-07 487 if (!is_fram) {
Pereira da Silva 2012-06-14 488 if (chip.flags & EE_ADDR1)
2007-02-12 489 addrlen = 1;
Pereira da Silva 2012-06-14 490 else if (chip.flags & EE_ADDR2)
2007-02-12 491 addrlen = 2;
Pereira da Silva 2012-06-14 492 else if (chip.flags & EE_ADDR3)
2007-02-12 493 addrlen = 3;
2007-02-12 494 else {
2007-02-12 495 dev_dbg(&spi->dev, "unsupported address type\n");
2013-05-28 496 return -EINVAL;
2007-02-12 497 }
2015-10-07 498 }
2007-02-12 499
2007-02-12 500 /* Ping the chip ... the status register is pretty portable,
2007-02-12 501 * unlike probing manufacturer IDs. We do expect that system
2007-02-12 502 * firmware didn't write it in the past few milliseconds!
2007-02-12 503 */
2007-02-12 504 sr = spi_w8r8(spi, AT25_RDSR);
2007-02-12 505 if (sr < 0 || sr & AT25_SR_nRDY) {
2007-03-16 506 dev_dbg(&spi->dev, "rdsr --> %d (%02x)\n", sr, sr);
2013-05-28 507 return -ENXIO;
2007-02-12 508 }
2007-02-12 509
2013-05-28 510 at25 = devm_kzalloc(&spi->dev, sizeof(struct at25_data), GFP_KERNEL);
2013-05-28 511 if (!at25)
2013-05-28 512 return -ENOMEM;
2007-02-12 513
2007-02-12 514 mutex_init(&at25->lock);
Pereira da Silva 2012-06-14 515 at25->chip = chip;
2007-02-12 516 at25->spi = spi_dev_get(spi);
2013-04-05 517 spi_set_drvdata(spi, at25);
2007-02-12 @518 at25->addrlen = addrlen;
2007-02-12 519
2015-10-07 520 if (is_fram) {
2015-10-07 521 /* Get ID of chip */
by commit
[PATCH] SPI eeprom driver
x>
xxxxxxxxxxxxxxxxx>
Open Source Technology Center
permail/kbuild-all">https://lists.01.org/pipermail/kbuild-all Intel Corporation
/a>
- Next message: Andrey Ryabinin: "[PATCH v2] lockd: get rid of reference-counted NSM RPC clients"
- Previous message: Prarit Bhargava: "Re: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch"
- In reply to: kbuild test robot: "Re: [PATCH] misc: eeprom: at25: add Cypress FRAM functionality"
- Next in thread: kbuild test robot: "Re: [PATCH] misc: eeprom: at25: add Cypress FRAM functionality"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]