Re: [linux-sunxi] Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi

[Hans de Goede]

Hi,

On 10/07/2015 05:01 PM, Stefan Monnier wrote:
> > @Maxime: How should we handle this? In its current form, the patch applies
> > only to the BananaPi dts by overriding the inherited opp from the SoC dtsi.
> > In an earlier discussion, it was said that this can be done, even though it
> > might not be the most elegant approach. But then again, I think it
> > shouldn't be necessary to change the opp in the sun7i-a20.dtsi for all A20
> > boards since this is - to my knowledge - the first and only report that an
> > A20 board has stability issues at the lower voltages (although not too many
> > boards use voltage scaling yet).
>
> IIUC this setting doesn't affect signals external to the A20, so it
> seems like it should be board-agnostic.

This setting configures the voltage at the pmic output pin, not at the SoC
power-input pins. And how much of the voltage actually makes it from the pmic
to the SoC definitely is board-specific. So we are going to need board-specific
opp-s in some cases (like this one for example).

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/