Re: [PATCH net-next 3/6] net: remove dsa.h include from linux/netdevice.h

[huangdaode]

On 2015/10/8 20:18, Jiri Pirko wrote:
> Thu, Oct 08, 2015 at 02:11:11PM CEST, huangdaode@xxxxxxxxxxxxx wrote:
> > On 2015/10/8 17:18, Jiri Pirko wrote:
> > > Thu, Oct 08, 2015 at 11:04:48AM CEST, lkp@xxxxxxxxx wrote:
> > > > Hi Vivien,
> > > >
> > > > [auto build test ERROR on net-next/master -- if it's inappropriate base, please ignore]
> > > >
> > > > config: arm64-allyesconfig (attached as .config)
> > > > reproduce:
> > > >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> > > >         chmod +x ~/bin/make.cross
> > > >         # save the attached .config to linux build tree
> > > >         make.cross ARCH=arm64
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > >    In file included from drivers/net/ethernet/hisilicon/hns/hnae.c:15:0:
> > > > > > drivers/net/ethernet/hisilicon/hns/hnae.h:465:2: error: unknown type name 'phy_interface_t'
> > > >      phy_interface_t phy_if;
> > > >      ^
> > > >
> > > > vim +/phy_interface_t +465 drivers/net/ethernet/hisilicon/hns/hnae.h
> > > Looks like hnae.c needs to do "#include <linux/phy.h>" directly.
> > > Cc'ing maintainer.
> > >
> > >
> > > > 6fe6611f huangdaode 2015-09-17  449  struct hnae_ae_dev {
> > > > 6fe6611f huangdaode 2015-09-17  450  	struct device cls_dev; /* the class dev */
> > > > 6fe6611f huangdaode 2015-09-17  451  	struct device *dev; /* the presented dev */
> > > > 6fe6611f huangdaode 2015-09-17  452  	struct hnae_ae_ops *ops;
> > > > 6fe6611f huangdaode 2015-09-17  453  	struct list_head node;
> > > > 6fe6611f huangdaode 2015-09-17  454  	struct module *owner; /* the module who provides this dev */
> > > > 6fe6611f huangdaode 2015-09-17  455  	int id;
> > > > 6fe6611f huangdaode 2015-09-17  456  	char name[AE_NAME_SIZE];
> > > > 6fe6611f huangdaode 2015-09-17  457  	struct list_head handle_list;
> > > > 6fe6611f huangdaode 2015-09-17  458  	spinlock_t lock; /* lock to protect the handle_list */
> > > > 6fe6611f huangdaode 2015-09-17  459  };
> > > > 6fe6611f huangdaode 2015-09-17  460
> > > > 6fe6611f huangdaode 2015-09-17  461  struct hnae_handle {
> > > > 6fe6611f huangdaode 2015-09-17  462  	struct device *owner_dev; /* the device which make use of this handle */
> > > > 6fe6611f huangdaode 2015-09-17  463  	struct hnae_ae_dev *dev;  /* the device who provides this handle */
> > > > 6fe6611f huangdaode 2015-09-17  464  	struct device_node *phy_node;
> > > > 6fe6611f huangdaode 2015-09-17 @465  	phy_interface_t phy_if;
> > > > 6fe6611f huangdaode 2015-09-17  466  	u32 if_support;
> > > > 6fe6611f huangdaode 2015-09-17  467  	int q_num;
> > > > 6fe6611f huangdaode 2015-09-17  468  	int vf_id;
> > > > 6fe6611f huangdaode 2015-09-17  469  	u32 eport_id;
> > > > 6fe6611f huangdaode 2015-09-17  470  	enum hnae_port_type port_type;
> > > > 6fe6611f huangdaode 2015-09-17  471  	struct list_head node;    /* list to hnae_ae_dev->handle_list */
> > > > 6fe6611f huangdaode 2015-09-17  472  	struct hnae_buf_ops *bops; /* operation for the buffer */
> > > > 6fe6611f huangdaode 2015-09-17  473  	struct hnae_queue **qs;  /* array base of all queues */
> > > >
> > > > :::::: The code at line 465 was first introduced by commit
> > > > :::::: 6fe6611ff275522a4e4c0359e2f46cdd07780d2f net: add Hisilicon Network Subsystem hnae framework support
> > > >
> > > > :::::: TO: huangdaode <huangdaode@xxxxxxxxxxxxx>
> > > > :::::: CC: David S. Miller <davem@xxxxxxxxxxxxx>
> > > >
> > > > ---
> > > > 0-DAY kernel test infrastructure                Open Source Technology Center
> > > > https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at  http://www.tux.org/lkml/
> > >
> > > .
> > Hi Jiri
> > thanks for your information. i have compiled the latest net-next repo using
> > your config file, but don't find the error you mentioned.
> > the attachment is the build log and the  config file.
> >
> > also, i used the following command to compile, but still fail to reproduce
> > your issue.
> > /  daode@Turing-Arch-b:~/work/net-next$ cat build.sh //
> > //        export ARCH=arm64 //
> > //        export CROSS_COMPILE=aarch64-linux-gnu-//
> > //        make allyesconfig//
> > //        make -j16 //
> > ////daode@Turing-Arch-b:~/work/net-next$ /
> >
> > so could you please help me to reproduce the issue.
> The patch is not in tree. That does not change the fact that you should
> include linux/phy.h directly. Please send the patch adding that. Thanks!
>
>
>
> .
ok,
thanks!

--
Best Regards
Daode Huang


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/