[PATCH RESEND 3/3] drm/amdgpu: fix memory leak
From: Sudip Mukherjee
Date: Thu Oct 08 2015 - 09:58:22 EST
If amdgpu_ib_get() fails we returned the error code but we missed
freeing ib.
Cc: "Christian KÃnig" <christian.koenig@xxxxxxx>
Cc: Jammy Zhou <Jammy.Zhou@xxxxxxx>
Cc: Chunming Zhou <david1.zhou@xxxxxxx>
Cc: Alex Deucher <alexander.deucher@xxxxxxx>
Cc: "monk.liu" <monk.liu@xxxxxxx>
Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
---
Sent on 18/09/2015
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 1e14531..53d551f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -455,8 +455,10 @@ int amdgpu_vm_update_page_directory(struct amdgpu_device *adev,
return -ENOMEM;
r = amdgpu_ib_get(ring, NULL, ndw * 4, ib);
- if (r)
+ if (r) {
+ kfree(ib);
return r;
+ }
ib->length_dw = 0;
/* walk over the address space and update the page directory */
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/