Re: [PATCH 3/5] block: nvme-core: simplify ida usage

[Keith Busch]

On Fri, 2 Oct 2015, Johannes Thumshirn wrote:
> Lee Duncan <lduncan@xxxxxxxx> writes:
> > Simplify ida index allocation and removal by
> > using the ida_simple_* helper functions.

Looks good to me. Just one comment:

> >  static void nvme_release_instance(struct nvme_dev *dev)
> >  {
> >  	spin_lock(&dev_list_lock);
> > -	ida_remove(&nvme_instance_ida, dev->instance);
> > +	ida_simple_remove(&nvme_instance_ida, dev->instance);
> >  	spin_unlock(&dev_list_lock);

No harm from taking the nvme spin lock here, but it's not necessary with
the simple interface.

> Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/