Re: [PATCH] serial: atmel: fix compiler warning on address cast

[Andre Przywara]

Hi,

On 08/10/15 11:38, Alexandre Belloni wrote:
> On 08/10/2015 at 10:37:49 +0100, Russell King - ARM Linux wrote :
>> On Thu, Oct 08, 2015 at 11:01:48AM +0200, Alexandre Belloni wrote:
>>> On 05/10/2015 at 18:00:52 +0100, Andre Przywara wrote :
>>>> Turning on KVM and LPAE support on top of a multi_v7_defconfig will
>>>> produce a compiler warning in the Atmel serial driver:
>>>> drivers/tty/serial/atmel_serial.c: In function 'atmel_verify_port':
>>>> drivers/tty/serial/atmel_serial.c:2299:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>>>   if ((void *)port->mapbase != ser->iomem_base)
>>>>       ^
>>>>
>>>> Fix that by using the cast on the right hand side instead, as similar
>>>> code already does in other drivers.
>>>>
>>>> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
>>> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
>>
>> Hmm, this actually points at a problem, and the cast screems out about it.
>> Think about it, can you guess what it is?

Russell, I'd really appreciate if we wouldn't have to play
"guess-what-I-am-thinking" here. Can't you just say what's bothering you?

> My understanding of the issue is that port->mapbase is a 64bit
> resource_size_t, and is larger than void * hence the warning. Casting
> iomem_base to unsigned long seems safe to me, am I wrong?

That is what I found out as well: it's comparing a physical address with
a pointer. And I tried to get to the root of this mismatch and fix it
there, but it turned out to be really old code to allow userspace to
setup serial ports by providing the MMIO address (IIRC this was for old
PC-style non-PnP serial ports some 20 years ago).
This whole concept is really outdated and probably does not make sense
at all for most drivers (except 8250 on i386).
Fixing this is a different task, I think, since it would impact most
serial drivers. I am happy to tackle this later, btw.

But this patch was just to fix the compiler warning I see every time now
and still meant for 4.3, so I kept it deliberately simple and contained.

Is that a solution we can agree on?

Cheers,
Andre.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/