RE: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed

[KY Srinivasan]

> -----Original Message-----
> From: Denis V. Lunev [mailto:den@xxxxxxxxxx]
> Sent: Thursday, October 8, 2015 10:20 AM
> To: KY Srinivasan <kys@xxxxxxxxxxxxx>; gregkh@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx;
> apw@xxxxxxxxxxxxx; vkuznets@xxxxxxxxxx; jasowang@xxxxxxxxxx
> Cc: Andrey Smetanin <asmetanin@xxxxxxxxxxxxx>; Haiyang Zhang
> <haiyangz@xxxxxxxxxxxxx>
> Subject: Re: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect
> failed
> 
> On 10/08/2015 05:01 AM, K. Y. Srinivasan wrote:
> > From: Denis V. Lunev <den@xxxxxxxxxx>
> 
> K.Y.,
> 
> there is one subtle thing in this submission. You have changed "From:"
> field in comparison with the original letter. I have submitted
> the patch with "From: Andrey Smetanin <asmetanin@xxxxxxxxxxxxx>"
> In this case Author: in the resulted git mainstream commit will
> be Andrey. With your submission the resulted Author will be I.
> 
> This was already happened once with
> 
> commit cc2dd4027a43bb36c846f195a764edabc0828602
> Author: Denis V. Lunev <den@xxxxxxxxxx>
> Date:   Sat Aug 1 16:08:20 2015 -0700
> 
>      mshyperv: fix recognition of Hyper-V guest crash MSR's
> 
> The situation looks a bit unfair.
> 
> Can we do something with that now/next time?

I am going to be resubmitting this series. I will fix it up.

Regards,

K. Y
> 
> Den
> 
> > Before vmbus_connect() synic is setup per vcpu - this means
> > hypervisor receives writes at synic msr's and probably allocate
> > hypervisor resources per synic setup.
> >
> > If vmbus_connect() failed for some reason it's neccessary to cleanup
> > synic setup by call hv_synic_cleanup() at each vcpu to get a chance
> > to free allocated resources by hypervisor per synic.
> >
> > This patch does appropriate cleanup in case of vmbus_connect() failure.
> >
> > Signed-off-by: Andrey Smetanin <asmetanin@xxxxxxxxxxxxx>
> > Signed-off-by: Denis V. Lunev <den@xxxxxxxxxx>
> > Reviewed-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> > CC: "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>
> > CC: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> > CC: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> > ---
> >   drivers/hv/vmbus_drv.c |    4 +++-
> >   1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> > index f19b6f7..3297731 100644
> > --- a/drivers/hv/vmbus_drv.c
> > +++ b/drivers/hv/vmbus_drv.c
> > @@ -867,7 +867,7 @@ static int vmbus_bus_init(int irq)
> >   	on_each_cpu(hv_synic_init, NULL, 1);
> >   	ret = vmbus_connect();
> >   	if (ret)
> > -		goto err_alloc;
> > +		goto err_connect;
> >
> >   	if (vmbus_proto_version > VERSION_WIN7)
> >   		cpu_hotplug_disable();
> > @@ -885,6 +885,8 @@ static int vmbus_bus_init(int irq)
> >
> >   	return 0;
> >
> > +err_connect:
> > +	on_each_cpu(hv_synic_cleanup, NULL, 1);
> >   err_alloc:
> >   	hv_synic_free();
> >   	hv_remove_vmbus_irq();

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/