Re: [PATCH] iio: mxs-lradc: Fix temperature offset

[Marek Vasut]

On Wednesday, October 07, 2015 at 09:12:56 AM, Stefan Wahren wrote:
> Am 07.10.2015 um 02:44 schrieb Alexandre Belloni:
> > Hi,
> > 
> > On 07/10/2015 at 01:19:09 +0200, Marek Vasut wrote :
> >>>> /* The calculated value from the ADC is in Kelvin, we
> >>>> * want Celsius for hwmon so the offset is
> >>>> - * -272.15 * scale
> >>>> + * -273.15 * scale
> >>>> */
> >>>> - *val = -1075;
> >>>> - *val2 = 691699;
> >>>> + *val = -1079;
> >>>> + *val2 = 644268;
> >>> 
> >>> i think it would be nice to break down the calculation of these magic
> >>> values in a second patch.
> >> 
> >> Indeed, I agree. I hope Alexandre can send another patch for that soon
> >> :-)
> > 
> > On my side, I'm not sure this is worth more than a comment. If
> > necessary, I can write that the datasheet specifies that the scale is
> > 4/1.012 here also.
> 
> I'm okay with that.

I'm fine either way, it's not worth wasting more time on this trivial stuff.
I'd say just pick this one.

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/